Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: threads in ping tests would hang indefinitely. #207

Merged
merged 8 commits into from
Jan 31, 2023
Merged

test: threads in ping tests would hang indefinitely. #207

merged 8 commits into from
Jan 31, 2023

Conversation

Unique-Divine
Copy link
Member

  1. Add hook that syncs pre-commit with poetry dependenceis
  2. feat: Network.from_chain_id() fn
  3. build: update dependencies
  4. build: Google Colab supports 3.8, so I updated the workflows and pyproject
  5. test: replace ping tests with requests.get calls on the rpc, lcd, and grpc - chore: update dependencies
  6. After updating the Python version, the isort and black pre-commit hooks were disagreeing, so I removed isort in favor of black since it's more powerful

@Unique-Divine
(1) add hook that syncs pre-commit with poetry dependenceis
78ffc2f 
(2) feat: Network.from_chain_id() fn
(3) build: update dependencies
@Unique-Divine
build: Google Colab supports 3.8
51197b2 
- test: replace ping tests with requests.get calls on the rpc, lcd, and
grpc
- chore: update dependencies
@onikonychev
Copy link
Collaborator

  1. After updating the Python version, the isort and black pre-commit hooks were disagreeing, so I removed isort in favor of black since it's more powerful

That was a bad idea. We lost imports sorting which black is not doing.
I returned it back and updated pre-commit module versions by pre-commit autoupdate.
Now they are all in sync.

@onikonychev onikonychev merged commit 437afb3 into master Jan 31, 2023
@onikonychev onikonychev deleted the fix-endpt-test branch January 31, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onikonychev onikonychev onikonychev approved these changes

@matthiasmatt matthiasmatt Awaiting requested review from matthiasmatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unique-Divine @onikonychev